| Summary: | [gyp] fix bundle resources for DumpRenderTree on mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||
| Component: | New Bugs | Assignee: | jochen | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, esprehn, thakis, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 99023 | ||||||
| Attachments: |
|
||||||
|
Description
jochen
2012-10-17 00:38:53 PDT
Created attachment 169108 [details]
Patch
I tested that this also gets the resources into Content Shell.app, but not into Chrome.app Comment on attachment 169108 [details]
Patch
This looks reasonable to me. Should we have a build step somewhere that checks that we don't leak these resources into Chrome.app? I guess Chrome.app shouldn't depend on TestRunner_resources...
Ideally thakis and/or tony^work would comment before we land this patch.
Comment on attachment 169108 [details]
Patch
I think this is fine.
Another possible approach would be do have a gypi file with the mac_bundle_resources block and just include that into the targets that need them, but if chrome ended up depending on TestRunner_resources that'd be bad anyway.
Comment on attachment 169108 [details] Patch Clearing flags on attachment: 169108 Committed r131613: <http://trac.webkit.org/changeset/131613> All reviewed patches have been landed. Closing bug. |