Bug 99558

Summary: [gyp] fix bundle resources for DumpRenderTree on mac
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, esprehn, thakis, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99023    
Attachments:
Description Flags
Patch none

jochen
Reported 2012-10-17 00:38:53 PDT
[gyp] fix bundle resources for DumpRenderTree on mac
Attachments
Patch (3.56 KB, patch)
2012-10-17 00:40 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-10-17 00:40:39 PDT
Created attachment 169108 [details] Patch
jochen
Comment 2 2012-10-17 00:42:36 PDT
I tested that this also gets the resources into Content Shell.app, but not into Chrome.app
Adam Barth
Comment 3 2012-10-17 08:45:13 PDT
Comment on attachment 169108 [details] Patch This looks reasonable to me. Should we have a build step somewhere that checks that we don't leak these resources into Chrome.app? I guess Chrome.app shouldn't depend on TestRunner_resources... Ideally thakis and/or tony^work would comment before we land this patch.
Nico Weber
Comment 4 2012-10-17 09:46:03 PDT
Comment on attachment 169108 [details] Patch I think this is fine. Another possible approach would be do have a gypi file with the mac_bundle_resources block and just include that into the targets that need them, but if chrome ended up depending on TestRunner_resources that'd be bad anyway.
WebKit Review Bot
Comment 5 2012-10-17 09:55:08 PDT
Comment on attachment 169108 [details] Patch Clearing flags on attachment: 169108 Committed r131613: <http://trac.webkit.org/changeset/131613>
WebKit Review Bot
Comment 6 2012-10-17 09:55:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.