Bug 99319

Summary: Web Inspector: Update CodeMirror to v3
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://codemirror.net
Bug Depends on:    
Bug Blocks: 94056, 94062, 94118    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review-

Jan Keromnes
Reported 2012-10-15 06:27:20 PDT
CodeMirror has a new version coming up, that should not only show still better performance, but it should also make the implementation of #94056 and #94062 fairly straightforward. As soon as v3 is stable enough, we should migrate our current CodeMirror code base to the new version.
Attachments
Patch (294.62 KB, patch)
2012-11-01 09:23 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (2.56 KB, patch)
2012-11-08 07:09 PST, Jan Keromnes 		pfeldman: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-11-01 09:23:46 PDT
Created attachment 171873 [details] Patch
WebKit Review Bot
Comment 2 2012-11-01 10:05:45 PDT
Comment on attachment 171873 [details] Patch Clearing flags on attachment: 171873 Committed r133189: <http://trac.webkit.org/changeset/133189>
WebKit Review Bot
Comment 3 2012-11-01 10:05:49 PDT
All reviewed patches have been landed. Closing bug.
Jan Keromnes
Comment 4 2012-11-08 07:09:36 PST
Reopening to attach new patch.
Jan Keromnes
Comment 5 2012-11-08 07:09:44 PST
Created attachment 173038 [details] Patch
Pavel Feldman
Comment 6 2012-11-08 07:39:33 PST
Comment on attachment 173038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57 > - CodeMirror.on(this._codeMirror, "change", this._change.bind(this)); Why this was wrong? It seems to work for me.
Vsevolod Vlasov
Comment 7 2012-11-08 07:42:54 PST
Please create a new bug for each patch.
Note You need to log in before you can comment on or make changes to this bug.