Bug 99319

Summary: Web Inspector: Update CodeMirror to v3
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://codemirror.net
Bug Depends on:    
Bug Blocks: 94056, 94062, 94118    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review-

Description Jan Keromnes 2012-10-15 06:27:20 PDT 
CodeMirror has a new version coming up, that should not only show still better performance, but it should also make the implementation of #94056 and #94062 fairly straightforward. As soon as v3 is stable enough, we should migrate our current CodeMirror code base to the new version.
Comment 1 Pavel Feldman 2012-11-01 09:23:46 PDT 
Created attachment 171873 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-01 10:05:45 PDT 
Comment on attachment 171873 [details]
Patch

Clearing flags on attachment: 171873

Committed r133189: <http://trac.webkit.org/changeset/133189>
Comment 3 WebKit Review Bot 2012-11-01 10:05:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Jan Keromnes 2012-11-08 07:09:36 PST 
Reopening to attach new patch.
Comment 5 Jan Keromnes 2012-11-08 07:09:44 PST 
Created attachment 173038 [details]
Patch
Comment 6 Pavel Feldman 2012-11-08 07:39:33 PST 
Comment on attachment 173038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57
> -    CodeMirror.on(this._codeMirror, "change", this._change.bind(this));

Why this was wrong? It seems to work for me.
Comment 7 Vsevolod Vlasov 2012-11-08 07:42:54 PST 
Please create a new bug for each patch.