Summary: | [Blackberry] makes NavigatorContentUtils work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris.Guan <logingx> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, mifenton, rakuco, rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris.Guan
2012-10-11 04:28:09 PDT
Created attachment 168193 [details]
Patch
Comment on attachment 168193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review > Source/WebKit/PlatformBlackBerry.cmake:-120 > - blackberry/WebCoreSupport/RegisterProtocolHandlerClientBlackBerry.cpp Don't you need to remove RegisterProtocolHandlerClientBlackBerry in this patch? (In reply to comment #2) > (From update of attachment 168193 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review > > > Source/WebKit/PlatformBlackBerry.cmake:-120 > > - blackberry/WebCoreSupport/RegisterProtocolHandlerClientBlackBerry.cpp > > Don't you need to remove RegisterProtocolHandlerClientBlackBerry in this patch? I did not find this file in upstream repo, I think someone removed it. Comment on attachment 168193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review LGTM. > Source/WebKit/PlatformBlackBerry.cmake:65 > +IF (ENABLE_NAVIGATOR_CONTENT_UTILS) Do you still need the ENABLE_CUSTOM_SCHEME_HANDLER part? (In reply to comment #4) > (From update of attachment 168193 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168193&action=review > > LGTM. > > > Source/WebKit/PlatformBlackBerry.cmake:65 > > +IF (ENABLE_NAVIGATOR_CONTENT_UTILS) > > Do you still need the ENABLE_CUSTOM_SCHEME_HANDLER part? yes, we need it now, CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER. see https://bugs.webkit.org/show_bug.cgi?id=93081. Comment on attachment 168193 [details] Patch Clearing flags on attachment: 168193 Committed r131056: <http://trac.webkit.org/changeset/131056> All reviewed patches have been landed. Closing bug. |