Summary: | [chromium] Expose background color in WebLayer and WebSolidColorLayer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Scott Violet <sky> | ||||||
Component: | WebKit Misc. | Assignee: | Iain Merrick <husky> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, piman, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Scott Violet
2012-10-08 17:53:49 PDT
Created attachment 167659 [details]
Fix for 98707:
Comment on attachment 167659 [details] Fix for 98707: View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review > Source/Platform/chromium/public/WebSolidColorLayer.h:43 > + virtual WebColor getBackgroundColor() const = 0; Not needed since you can get it through layer() Comment on attachment 167659 [details] Fix for 98707: View in context: https://bugs.webkit.org/attachment.cgi?id=167659&action=review > Source/Platform/chromium/public/WebLayer.h:122 > + virtual WebColor getBackgroundColor() const = 0; naming nit: just "backgroundColor()" Created attachment 167763 [details]
Fix v2
getBackgroundColor -> backgroundColor and removes changes to WebSolidColorLayer.
Looks good, we'll just have to wait for the chromium side to land + roll into Source/WebKit/chromium/DEPS Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 167763 [details] Fix v2 Rejecting attachment 167763 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Core/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 https://bugs.webkit.org/show_bug.cgi?id=95664 When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14245741 Comment on attachment 167763 [details] Fix v2 Clearing flags on attachment: 167763 Committed r131013: <http://trac.webkit.org/changeset/131013> All reviewed patches have been landed. Closing bug. |