Bug 98657

Summary: [EFL][WK2] Simplify frame flattening support in MiniBrowser
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, ryuan.choi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98649    
Bug Blocks:    
Attachments:
Description Flags
Patch
kenneth: review+, webkit.review.bot: commit-queue-
Patch for landing none

Chris Dumez
Reported 2012-10-08 09:43:16 PDT
The frame_flattening setting is currently being passed around to the window_create() function which is not the most convenient. We should find a nicer way to support frame flattening in MiniBrowser.
Attachments
Patch (4.19 KB, patch)
2012-10-08 09:49 PDT, Chris Dumez 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (4.24 KB, patch)
2012-10-08 10:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-08 09:49:16 PDT
Created attachment 167550 [details] Patch
WebKit Review Bot
Comment 2 2012-10-08 10:20:26 PDT
Comment on attachment 167550 [details] Patch Rejecting attachment 167550 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: er/efl/main.c Hunk #3 FAILED at 168. Hunk #4 succeeded at 226 (offset 2 lines). Hunk #5 succeeded at 304 (offset 2 lines). Hunk #6 succeeded at 335 (offset 2 lines). Hunk #7 succeeded at 372 (offset 2 lines). Hunk #8 succeeded at 396 (offset 2 lines). 1 out of 8 hunks FAILED -- saving rejects to file Tools/MiniBrowser/efl/main.c.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14223295
Chris Dumez
Comment 3 2012-10-08 10:25:09 PDT
Created attachment 167555 [details] Patch for landing Rebased on master. Could someone please cq+?
WebKit Review Bot
Comment 4 2012-10-08 11:23:00 PDT
Comment on attachment 167555 [details] Patch for landing Clearing flags on attachment: 167555 Committed r130658: <http://trac.webkit.org/changeset/130658>
WebKit Review Bot
Comment 5 2012-10-08 11:23:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.