Bug 98560 – Rendering/Layout issue of CJK vertical text with some font

• Component: Platform
• Status: RESOLVED DUPLICATE

[Xianzhu Wang]

Created attachment 167392 [details]
test case (html)

Save both of the test case files and open the HTML in Mac browser.

Actual result:
1) The vertical line is wrapped;
2) The '}' character and the previous CJK character overlaps

Expected
1) No wrapping
2) No overlapping

[Xianzhu Wang]

Created attachment 167393 [details]
test case (font file)

[Xianzhu Wang]

Created attachment 167395 [details]
Current DRT pixel result

[Enrica Casucci]

I think this is a regression from r130443.
I'll post a fix shortly for it.

[Enrica Casucci]

I confirmed that my fix solved this issue.
I'll post a patch.

[Enrica Casucci]

Created attachment 167575 [details]
Patch

[Tony Chang]

Comment on attachment 167575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167575&action=review

Can you make a layout test from the attached files on this bug?

> Source/WebCore/ChangeLog:11
> +        Fixes a regression introduced with r130443.
> +
> +        * platform/graphics/FontFastPath.cpp:
> +        (WebCore::Font::glyphDataAndPageForCharacter):

Please describe the fix here.

[Enrica Casucci]

(In reply to comment #6)
> (From update of attachment 167575 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167575&action=review
> 
> Can you make a layout test from the attached files on this bug?
> 
> > Source/WebCore/ChangeLog:11
> > +        Fixes a regression introduced with r130443.
> > +
> > +        * platform/graphics/FontFastPath.cpp:
> > +        (WebCore::Font::glyphDataAndPageForCharacter):
> 
> Please describe the fix here.

I thought it was straightforward. I'll add a comment and the test.

[Enrica Casucci]

Resolving as duplicate. I'll post the updated patch in the original bug and update the TestExpectations also for Mac.

*** This bug has been marked as a duplicate of bug 98545 ***