Bug 98187

Summary: Remove cases of testRunner.disableImageLoading() from the layout tests.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98083    
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2012-10-02 12:15:56 PDT
Remove cases of testRunner.disableImageLoading() from the layout tests.
Attachments
Patch (2.68 KB, patch)
2012-10-02 12:19 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-10-02 12:19:24 PDT
Created attachment 166729 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-10-02 12:46:04 PDT
Comment on attachment 166729 [details] Patch Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests?
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-10-02 13:16:51 PDT
(In reply to comment #2) > (From update of attachment 166729 [details]) > Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests? The behavior seems to be port-dependent -- at least the Mac (and thus probably win), EFL, GTK+ and Chromium TestRunners reset that value between each test. WTR seems to do that as well by calling WKPreferencesResetTestRunnerOverrides().
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-10-02 13:19:37 PDT
Comment on attachment 166729 [details] Patch Clearing flags on attachment: 166729 Committed r130201: <http://trac.webkit.org/changeset/130201>
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-10-02 13:19:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.