Bug 98187

Summary:

Remove cases of testRunner.disableImageLoading() from the layout tests.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

Tools / Tests

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

98083

Attachments:

Description	Flags
Patch	none

Description Raphael Kubo da Costa (:rakuco) 2012-10-02 12:15:56 PDT

Remove cases of testRunner.disableImageLoading() from the layout tests.

Comment 1 Raphael Kubo da Costa (:rakuco) 2012-10-02 12:19:24 PDT

Created attachment 166729 [details]
Patch

Comment 2 Simon Fraser (smfr) 2012-10-02 12:46:04 PDT

Comment on attachment 166729 [details]
Patch

Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests?

Comment 3 Raphael Kubo da Costa (:rakuco) 2012-10-02 13:16:51 PDT

(In reply to comment #2)
> (From update of attachment 166729 [details])
> Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests?

The behavior seems to be port-dependent -- at least the Mac (and thus probably win), EFL, GTK+ and Chromium TestRunners reset that value between each test. WTR seems to do that as well by calling WKPreferencesResetTestRunnerOverrides().

Comment 4 Raphael Kubo da Costa (:rakuco) 2012-10-02 13:19:37 PDT

Comment on attachment 166729 [details]
Patch

Clearing flags on attachment: 166729

Committed r130201: <http://trac.webkit.org/changeset/130201>

Comment 5 Raphael Kubo da Costa (:rakuco) 2012-10-02 13:19:48 PDT

All reviewed patches have been landed.  Closing bug.