| Summary: | Missing sys/mman.h include on Mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Liu <net147> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, darin, hausmann, webkit.review.bot, zeno | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jonathan Liu
2012-10-01 16:16:23 PDT
Created attachment 166567 [details]
Patch
I want to r+ this based on the comment you cited, but I don't understand why the build isn't broken because of this. An indirect include from one of the other headers perhaps. I don't understand why this is needed. The Mac (apple & QT) bots are green. (In reply to comment #4) > I don't understand why this is needed. The Mac (apple & QT) bots are green. See https://bugs.webkit.org/show_bug.cgi?id=97995#c5 Comment on attachment 166567 [details]
Patch
Eventually we’ll have to figure out a policy for Mac includes. Generally speaking the Mac port works by including certain global includes as part of the prefix, and patches like this are only needed because some other ports are leaving things out of the global prefix. But since we have a "config.h" that is used on all platforms, these could instead be fixed by adding more to the "config.h" or something it includes on those ports. Instead of constantly taking small patches like this one.
But I’ll set that aside for now and say r=me
Comment on attachment 166567 [details] Patch Clearing flags on attachment: 166567 Committed r139926: <http://trac.webkit.org/changeset/139926> All reviewed patches have been landed. Closing bug. |