| Summary: | Remove testRunner.disableImageLoading() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||
| Component: | Tools / Tests | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, mifenton, rwlbuis, tonikitoo, webkit.review.bot, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 98187, 98200 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 175671 [details]
Patch
Comment on attachment 175671 [details] Patch Rejecting attachment 175671 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: mpRenderTree/mac/TestRunnerMac.mm Hunk #1 succeeded at 631 (offset 5 lines). patching file Tools/DumpRenderTree/qt/TestRunnerQt.cpp Hunk #1 succeeded at 563 with fuzz 1. patching file Tools/DumpRenderTree/qt/TestRunnerQt.h patching file Tools/DumpRenderTree/win/TestRunnerWin.cpp patching file Tools/DumpRenderTree/wx/TestRunnerWx.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15236019 Thanks for the review, manually landed in r137080. http://trac.webkit.org/changeset/137080 |
testRunner.overridePreference("WebKitDisplayImagesKey", 0) achieves the same effect, and we tend to prefer adding these settings to overridePreferences (see the discussion in http://lists.webkit.org/pipermail/webkit-dev/2012-September/022323.html). There is only one test that calls disableImageLoading(), but we need to check that there are no ports which implement disableImageLoading() but not overridePreference("WebKitDisplayImagesKey", ...).