Bug 97852

Summary: Remove unused features and reduce code duplications in PerfTestRunner
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, morrita, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97833    
Attachments:
Description Flags
Patch
none
Fixed a typo in ChangeLog haraken: review+

Description Ryosuke Niwa 2012-09-27 20:29:20 PDT
Remove unused features and reduce code duplications in PerfTestRunner
Comment 1 Ryosuke Niwa 2012-09-27 20:40:28 PDT
Created attachment 166132 [details]
Patch
Comment 2 Kentaro Hara 2012-09-27 20:50:49 PDT
Comment on attachment 166132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166132&action=review

> PerformanceTests/ChangeLog:9
> +        - Remove PerfTestRunner.log since it's never used.

Nit: PerfTestRunner.info?

> PerformanceTests/resources/runner.js:190
> +        return returnValue;
> +    }
>  
> -    var mallocMemoryStats = PerfTestRunner.computeStatistics([PerfTestRunner.getUsedMallocHeap()], "bytes");
> -    PerfTestRunner.printStatistics(mallocMemoryStats, "Malloc:");
> +    return end - start;

Is this correct? This function sometimes returns returnValue and sometimes returns end-start.
Comment 3 Ryosuke Niwa 2012-09-27 20:55:33 PDT
Comment on attachment 166132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166132&action=review

>> PerformanceTests/ChangeLog:9
>> +        - Remove PerfTestRunner.log since it's never used.
> 
> Nit: PerfTestRunner.info?

Right.

>> PerformanceTests/resources/runner.js:190
>> +    return end - start;
> 
> Is this correct? This function sometimes returns returnValue and sometimes returns end-start.

Yes. When test.run returns a number, we use that value instead (see dom-perf.js for example).
Comment 4 Ryosuke Niwa 2012-09-27 20:56:15 PDT
Created attachment 166136 [details]
Fixed a typo in ChangeLog
Comment 5 Kentaro Hara 2012-09-27 21:08:20 PDT
Comment on attachment 166136 [details]
Fixed a typo in ChangeLog

Looks OK