Bug 97658 – [Cairo] Bump Cairo to fix more canvas/philip tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dominik Röttsches (drott)]

We've continued the analysis from 
https://bugs.webkit.org/show_bug.cgi?id=54458#c7
and worked with Chris Wilson to address some of these issue. 

We've experimentally bumped cairo to 1.12 which has introduced new regressions:
fast/canvas/canvas-fillRect-gradient-shadow.html = TEXT
svg/batik/text/smallFonts.svg = TEXT
svg/batik/text/textGlyphOrientationHorizontal.svg = TEXT
svg/batik/text/textOnPath2.svg = TEXT
svg/batik/text/textOnPath3.svg = TEXT
svg/batik/text/textOnPathSpaces.svg = TEXT
svg/batik/text/verticalTextOnPath.svg = TEXT
svg/hixie/perf/001.xml = TEXT
svg/hixie/perf/002.xml = TEXT
svg/stroke/zero-length-path-linecap-rendering.svg = TEXT
svg/stroke/zero-length-subpaths-linecap-rendering.svg = TEXT
svg/transforms/transformed-text-fill-pattern.html = IMAGE

For which we filed 
https://bugs.freedesktop.org/show_bug.cgi?id=54446 "WebKit regression observed in Cairo commit 83bfd85"  (now resolved)
https://bugs.freedesktop.org/show_bug.cgi?id=54507 "WebKit regression found in Cairo commit 51594d9" (under investigation)

Once the second bug can be resolved (on either cairo side or WebKit side), we should be able to bump Cairo to at least f34b87f6d76cbea93acd4a8c73c8c6a6b412a302 or a release version after this commit.

This would resolve failures for (no webkit bugs):

2d.path.rect.selfintersect.html
canvas/philip/tests/2d.path.rect.zero.6.html
canvas/philip/tests/2d.path.arc.zeroradius.html

WebKit Bug 54471:
canvas/philip/tests/2d.path.arc.selfintersect.1.html
canvas/philip/tests/2d.path.arc.shape.3.html

[Dominik Röttsches (drott)]

*** Bug 54471 has been marked as a duplicate of this bug. ***

[Sudarsana Nagineni (babu)]

The stroke and hixie/perf tests are addressed in Cairo bug https://bugs.freedesktop.org/show_bug.cgi?id=54549 (commit b0c466e)

[Sudarsana Nagineni (babu)]

Created attachment 167773 [details]
Patch

Bumped the cairo to version 1.12.4 in the jhbuild files for EFL and GTK. Also, unskipped canvas/philip tests which are passing now and updated platform-specific baselines for svg tests.

[Martin Robinson]

I'm not sure if I understand the new shadow failure. Shadows are not rendered with Cairo, rather the shadow code works with the pixels of the image directly.

[Sudarsana Nagineni (babu)]

Created attachment 167882 [details]
Patch

Updated the test case of new shadow failure in the bug #98760, after discussing with Martin a bit more.

[WebKit Review Bot]

Comment on attachment 167882 [details]
Patch

Clearing flags on attachment: 167882

Committed r130840: <http://trac.webkit.org/changeset/130840>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.