| Summary: | Perf-o-matic should store "values" and support array'ed input | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, morrita | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 77037, 97611 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2012-09-25 13:56:45 PDT
Because we've added results page, results JSON now contains an array instead of dictionary as the top level structure. We've also added "values" to some tests' results so that we may compute statistics later. Perf-o-matic needs to incorporate these changes in the JSON format. Created attachment 165668 [details]
Patch
Comment on attachment 165668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165668&action=review > Websites/webkit-perf.appspot.com/app.yaml:2 > +version: 20 nit: I've found it's useful to have the version of an application track the revision in svn for when the change lands. Just a suggestion if it's useful to you ... Committed r129555: <http://trac.webkit.org/changeset/129555> Comment on attachment 165668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165668&action=review Thanks for the review. >> Websites/webkit-perf.appspot.com/app.yaml:2 >> +version: 20 > > nit: I've found it's useful to have the version of an application track the revision in svn for when the change lands. Just a suggestion if it's useful to you ... That sounds tricky. It means that I have to predict at which revision my change lands... (In reply to comment #5) > (From update of attachment 165668 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165668&action=review > > Thanks for the review. > > >> Websites/webkit-perf.appspot.com/app.yaml:2 > >> +version: 20 > > > > nit: I've found it's useful to have the version of an application track the revision in svn for when the change lands. Just a suggestion if it's useful to you ... > > That sounds tricky. It means that I have to predict at which revision my change lands... What I do is to leave the version in app.yaml alone and specify the version the change lands on upload, e.g., appcfg.py upload -V r123456 . |