Summary: | IndexedDB: Split up setVersion and deleteDatabase sequencing tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alecflett, dgrogan, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 97051, 97368 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Joshua Bell
2012-09-24 14:25:50 PDT
Created attachment 165448 [details]
Patch
Nice simple tests now. We should get these running under chromium's browser_layouttests if they work. dgrogan@, alecflett@ - any comments before sending this off for review? tony@ - r? Just splitting up tests previous updated in webkit.org/b/97051 and webkit.org/b/97368 Comment on attachment 165448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165448&action=review > LayoutTests/storage/indexeddb/setversion-not-blocked.html:7 > +<script src="resources/setversion-not-blocked.js"></script> Nit: I would just inline js files that are only used in a single test. Less files in the tree and easier to find the code related to the test. (In reply to comment #5) > Nit: I would just inline js files that are only used in a single test. Less files in the tree and easier to find the code related to the test. We're planning make *-worker.html variants for nearly all of these tests at some point soon - and autogenerate the minimal HTML wrappers as well - hence this pattern. Created attachment 166064 [details]
Patch for landing
Comment on attachment 166064 [details] Patch for landing Clearing flags on attachment: 166064 Committed r129809: <http://trac.webkit.org/changeset/129809> All reviewed patches have been landed. Closing bug. |