| Summary: | Use emptyString instead of String("") | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
| Component: | WebCore Misc. | Assignee: | Patrick R. Gansterer <paroga> | ||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||
| Severity: | Normal | CC: | abarth, annevk, benjamin, haraken, japhet, mifenton, rwlbuis, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 86305 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 165110 [details]
Patch
Comment on attachment 165110 [details]
Patch
My understanding is that emptyString is only safe to use on the main thread. Many of these lines of code look like they can be reached on worker threads.
(Also see https://bugs.webkit.org/show_bug.cgi?id=95793 ) git grep cannot find these instances anymore. |
Use emptyString instead of String("")