Bug 97320

Summary:

Use emptyString instead of String("")

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

WebCore Misc.

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

abarth, annevk, benjamin, haraken, japhet, mifenton, rwlbuis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

86305

Bug Blocks:

Attachments:

Description	Flags
Patch	abarth: review-

Patrick R. Gansterer

Reported 2012-09-21 03:36:45 PDT

Use emptyString instead of String("")

Attachments
Patch (14.26 KB, patch) 2012-09-21 03:46 PDT, Patrick R. Gansterer	abarth: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2012-09-21 03:46:35 PDT

Created attachment 165110 [details] Patch

Adam Barth

Comment 2 2012-09-21 09:09:40 PDT

Comment on attachment 165110 [details] Patch My understanding is that emptyString is only safe to use on the main thread. Many of these lines of code look like they can be reached on worker threads.

Benjamin Poulain

Comment 3 2012-09-21 14:14:51 PDT

(Also see https://bugs.webkit.org/show_bug.cgi?id=95793 )

Anne van Kesteren

Comment 4 2023-12-28 08:35:32 PST

git grep cannot find these instances anymore.

Note You need to log in before you can comment on or make changes to this bug.