Bug 96807

Summary: IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Joshua Bell 2012-09-14 10:53:50 PDT 
IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
Comment 1 Joshua Bell 2012-09-14 10:58:53 PDT 
Created attachment 164192 [details]
Patch
Comment 2 Joshua Bell 2012-09-14 10:59:31 PDT 
This is one of the pieces factored out of http://webkit.org/b/90411

dgrogan@ - can you take a look?
Comment 3 David Grogan 2012-09-14 14:04:13 PDT 
Comment on attachment 164192 [details]
Patch

LGTM
Comment 4 Joshua Bell 2012-09-14 14:49:28 PDT 
tony@ - they just keep coming! r?
Comment 5 Tony Chang 2012-09-14 14:55:52 PDT 
Comment on attachment 164192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164192&action=review

> Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp:109
> +        // If connection closed between onUpgradeNeeded and onSuccess, an error

Nit: If /the/ connection
Comment 6 Joshua Bell 2012-09-14 15:34:49 PDT 
Created attachment 164239 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-09-14 17:08:20 PDT 
Comment on attachment 164239 [details]
Patch for landing

Clearing flags on attachment: 164239

Committed r128674: <http://trac.webkit.org/changeset/128674>
Comment 8 WebKit Review Bot 2012-09-14 17:08:23 PDT 
All reviewed patches have been landed.  Closing bug.