Summary: | Make computeLogicalHeight virtual and updateLogicalHeight non-virtual. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
Component: | Layout and Rendering | Assignee: | Rob Buis <rbuis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | changseok, donggwan.kim, esprehn+autocc, ews-watchlist, glenn, hyatt, kondapallykalyan, leviw, mstensho, ntim, pdr, rbuis, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 97049, 97263, 97475, 97486, 98677, 99348 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Tony Chang
2012-09-14 10:17:33 PDT
computeLogicalHeight is now virtual, however, I can't make updateLogicalHeight virtual because of RenderMultiColumnSet, which sets a member variable during updateLogicalHeight. It looks like that variable is the same as logicalHeight right now, but the comments suggest that there is a future use for it. I'd like to remove RenderMultiColumnSet::m_computedColumnHeight. Yeah, you're not going to be able to remove this. It's going to be needed. FYI: the RenderMultiColumnSet::updateLogicalHeight() override is going away with the fix for https://bugs.webkit.org/show_bug.cgi?id=116033 , but in the meantime (after this bug was reported) RenderRegion::updateLogicalHeight() has appeared. Created attachment 462358 [details]
Patch
r=me Committed 254564@main (c096c71bf576): <https://commits.webkit.org/254564@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462358 [details]. |