Bug 99348 - Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
Summary: Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 96804
  Show dependency tree / graph
 
Reported: 2012-10-15 12:13 PDT by Tony Chang
Modified: 2012-10-15 19:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.17 KB, patch)
2012-10-15 12:17 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (5.40 KB, patch)
2012-10-15 13:15 PDT, Tony Chang 		tony: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-10-15 12:13:41 PDT 
Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
Comment 1 Tony Chang 2012-10-15 12:17:55 PDT 
Created attachment 168752 [details]
Patch
Comment 2 Tony Chang 2012-10-15 12:19:45 PDT 
Last one.  After this, I should be able to clean up a bunch of code that saves the oldHeight, calls updateLogicalHeight, then restores the oldHeight.
Comment 3 Ojan Vafai 2012-10-15 12:24:34 PDT 
Comment on attachment 168752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168752&action=review

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:69
>  void RenderMultiColumnSet::updateLogicalHeight()
>  {
>      // Make sure our column height is up to date.

FIXME maybe? To point out that this is the last method to be removed in order to make updateLogicalHeight non-virtual?
Comment 4 Tony Chang 2012-10-15 13:15:32 PDT 
Created attachment 168768 [details]
Patch for landing
Comment 5 Tony Chang 2012-10-15 13:54:45 PDT 
Committed r131351: <http://trac.webkit.org/changeset/131351>