Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
Created attachment 165434 [details] Patch
Comment on attachment 165434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review > Source/WebCore/rendering/RenderMeter.cpp:71 > + LayoutRect frame = frameRect(); > + if (isHorizontalWritingMode()) > + frame.setHeight(computedValues.m_extent); > + else > + frame.setWidth(computedValues.m_extent); Dead code?
Created attachment 165436 [details] Patch
Comment on attachment 165434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review >> Source/WebCore/rendering/RenderMeter.cpp:71 >> + frame.setWidth(computedValues.m_extent); > > Dead code? Oops, fixed the code below it to use |frame|.
Comment on attachment 165436 [details] Patch Clearing flags on attachment: 165436 Committed r129409: <http://trac.webkit.org/changeset/129409>
All reviewed patches have been landed. Closing bug.