Bug 97475 - Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
Summary: Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 96804
  Show dependency treegraph
 
Reported: 2012-09-24 12:31 PDT by Tony Chang
Modified: 2012-09-24 14:11 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2012-09-24 13:11 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2012-09-24 13:26 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-09-24 12:31:29 PDT
Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight
Comment 1 Tony Chang 2012-09-24 13:11:57 PDT
Created attachment 165434 [details]
Patch
Comment 2 Ojan Vafai 2012-09-24 13:21:31 PDT
Comment on attachment 165434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review

> Source/WebCore/rendering/RenderMeter.cpp:71
> +    LayoutRect frame = frameRect();
> +    if (isHorizontalWritingMode())
> +        frame.setHeight(computedValues.m_extent);
> +    else
> +        frame.setWidth(computedValues.m_extent);

Dead code?
Comment 3 Tony Chang 2012-09-24 13:26:14 PDT
Created attachment 165436 [details]
Patch
Comment 4 Tony Chang 2012-09-24 13:26:39 PDT
Comment on attachment 165434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165434&action=review

>> Source/WebCore/rendering/RenderMeter.cpp:71
>> +        frame.setWidth(computedValues.m_extent);
> 
> Dead code?

Oops, fixed the code below it to use |frame|.
Comment 5 WebKit Review Bot 2012-09-24 14:11:29 PDT
Comment on attachment 165436 [details]
Patch

Clearing flags on attachment: 165436

Committed r129409: <http://trac.webkit.org/changeset/129409>
Comment 6 WebKit Review Bot 2012-09-24 14:11:32 PDT
All reviewed patches have been landed.  Closing bug.