Bug 96746

Summary:

Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script

Product:

WebKit

Reporter:

Andrey Adaikin <aandrey>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Adaikin <aandrey>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

97203

Attachments:

Description	Flags
Patch	none
Patch	none
Rebased	none
Rebased	none

Andrey Adaikin

Reported 2012-09-14 03:17:19 PDT

First step towards the 2D canvas instrumentation from the WebGL injected script module side. Next: support this from the inspector instrumentation C++ code. Next: rename [WebGL] to [Canvas]

Attachments
Patch (15.60 KB, patch) 2012-09-14 03:20 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Patch (16.09 KB, patch) 2012-09-19 03:29 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Rebased (16.13 KB, patch) 2012-09-20 04:50 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Rebased (16.18 KB, patch) 2012-09-24 08:25 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrey Adaikin

Comment 1 2012-09-14 03:20:11 PDT

Created attachment 164087 [details] Patch

Andrey Adaikin

Comment 2 2012-09-14 03:25:07 PDT

Note for reviewers: - Canvas 2D context specs: http://www.w3.org/TR/2dcontext/ - Excerpts about the 2D context state: Each context maintains a stack of drawing states. Drawing states consist of: - The current transformation matrix. - The current clipping region. - The current values of the following attributes: strokeStyle, fillStyle, globalAlpha, lineWidth, lineCap, lineJoin, miterLimit, shadowOffsetX, shadowOffsetY, shadowBlur, shadowColor, globalCompositeOperation, font, textAlign, textBaseline. - The current default path is NOT part of the drawing state. The current default path is persistent, and can only be reset using the beginPath() method.

Vsevolod Vlasov

Comment 3 2012-09-19 00:53:49 PDT

Comment on attachment 164087 [details] Patch Please explain what you are doing here in ChangeLog.

Andrey Adaikin

Comment 4 2012-09-19 03:29:33 PDT

Created attachment 164706 [details] Patch

Andrey Adaikin

Comment 5 2012-09-20 04:50:50 PDT

Created attachment 164893 [details] Rebased

Andrey Adaikin

Comment 6 2012-09-24 08:25:45 PDT

Created attachment 165387 [details] Rebased

WebKit Review Bot

Comment 7 2012-09-24 09:49:58 PDT

Comment on attachment 165387 [details] Rebased Rejecting attachment 165387 [details] from commit-queue. aandrey@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Review Bot

Comment 8 2012-09-24 09:59:00 PDT

Comment on attachment 165387 [details] Rebased Clearing flags on attachment: 165387 Committed r129383: <http://trac.webkit.org/changeset/129383>

WebKit Review Bot

Comment 9 2012-09-24 09:59:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.