Bug 96712

Summary:

Fix unused parameter compile warnings in WebCore.

Product:

WebKit

Reporter:

Kangil Han <kangil.han>

Component:

WebCore Misc.

Assignee:

Kangil Han <kangil.han>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, danw, eric.carlson, eric, feature-media-reviews, gustavo, gyuyoung.kim, jamesr, japhet, menard, mrobinson, pnormand, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

63526

Attachments:

Description	Flags
patch	none
patch	rniwa: review+
patch	none
patch	none

Kangil Han

Reported 2012-09-13 17:33:13 PDT

There are several unused parameter warnings found during EFL build.

Attachments
patch (47.93 KB, patch) 2012-09-13 21:44 PDT, Kangil Han	no flags	Details Formatted Diff Diff
patch (47.94 KB, patch) 2012-09-13 21:53 PDT, Kangil Han	rniwa: review+	Details Formatted Diff Diff
patch (47.88 KB, patch) 2012-09-13 23:45 PDT, Kangil Han	no flags	Details Formatted Diff Diff
patch (47.88 KB, patch) 2012-09-13 23:57 PDT, Kangil Han	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kangil Han

Comment 1 2012-09-13 21:44:00 PDT

Created attachment 164044 [details] patch

WebKit Review Bot

Comment 2 2012-09-13 21:46:08 PDT

Attachment 164044 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:93: Missing space inside { }. [whitespace/braces] [5] Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479: init_source is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489: fill_input_buffer is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kangil Han

Comment 3 2012-09-13 21:53:43 PDT

Created attachment 164045 [details] patch

WebKit Review Bot

Comment 4 2012-09-13 21:55:23 PDT

Attachment 164045 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479: init_source is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489: fill_input_buffer is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kangil Han

Comment 5 2012-09-13 22:00:27 PDT

(In reply to comment #4) > Attachment 164045 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479: init_source is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] > Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489: fill_input_buffer is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] > Total errors found: 2 in 45 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I don't think I could fix these style errors. It was already there.

Gyuyoung Kim

Comment 6 2012-09-13 22:05:37 PDT

(In reply to comment #5) > > If any of these errors are false positives, please file a bug against check-webkit-style. > > I don't think I could fix these style errors. > It was already there. It looks this style error has existed before.

Ryosuke Niwa

Comment 7 2012-09-13 23:37:05 PDT

Comment on attachment 164045 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=164045&action=review > Source/WebCore/platform/efl/PasteboardEfl.cpp:86 > + bool, bool&) Wrong indentation! Also, you can fit bool & bool& on the previous line.

Ryosuke Niwa

Comment 8 2012-09-13 23:37:12 PDT

Kangil Han

Comment 9 2012-09-13 23:45:37 PDT

Created attachment 164057 [details] patch Done, thanks!

WebKit Review Bot

Comment 10 2012-09-13 23:47:48 PDT

Attachment 164057 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479: init_source is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489: fill_input_buffer is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 11 2012-09-13 23:48:38 PDT

Comment on attachment 164057 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=164057&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Missing reviewer name though this patch is reviewed by rniwa.

Kangil Han

Comment 12 2012-09-13 23:55:41 PDT

(In reply to comment #11) > (From update of attachment 164057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164057&action=review > > > Source/WebCore/ChangeLog:6 > > + Reviewed by NOBODY (OOPS!). > > Missing reviewer name though this patch is reviewed by rniwa. oops.. i will get back soon..

Kangil Han

Comment 13 2012-09-13 23:57:07 PDT

Created attachment 164060 [details] patch Done!

WebKit Review Bot

Comment 14 2012-09-13 23:59:21 PDT

Attachment 164060 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479: init_source is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489: fill_input_buffer is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 15 2012-09-14 00:31:45 PDT

This patch should pass all ews.

WebKit Review Bot

Comment 16 2012-09-14 01:42:23 PDT

Comment on attachment 164060 [details] patch Clearing flags on attachment: 164060 Committed r128570: <http://trac.webkit.org/changeset/128570>

WebKit Review Bot

Comment 17 2012-09-14 01:42:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.