Bug 96700

Summary: [V8] Binding: Generate batched attribute/const/callback struct names can collide
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90411    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Joshua Bell
Reported 2012-09-13 15:03:04 PDT
[V8] Binding: Generate batched attribute/const/callback structs into namespace
Attachments
Patch (29.42 KB, patch)
2012-09-13 15:05 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (26.23 KB, patch)
2012-09-13 15:16 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.28 KB, patch)
2012-09-13 15:21 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-09-13 15:05:34 PDT
Created attachment 163974 [details] Patch
Joshua Bell
Comment 2 2012-09-13 15:06:03 PDT
I'm thinking of revising this to avoid the namespace, and just name the tables V8<ClassName>Callbacks (etc) instead.
Joshua Bell
Comment 3 2012-09-13 15:16:15 PDT
Created attachment 163978 [details] Patch
Joshua Bell
Comment 4 2012-09-13 15:16:47 PDT
Revised patch - Just adds a "V8" prefix to the struct names. Much less churn.
Joshua Bell
Comment 5 2012-09-13 15:18:04 PDT
abarth@ or haraken@ - r?
Kentaro Hara
Comment 6 2012-09-13 15:18:30 PDT
Comment on attachment 163978 [details] Patch Looks better than introducing namespaces.
Joshua Bell
Comment 7 2012-09-13 15:20:03 PDT
... and I'll fix the changelog entry about no new tests.
Joshua Bell
Comment 8 2012-09-13 15:21:31 PDT
Created attachment 163980 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-09-13 16:01:13 PDT
Comment on attachment 163980 [details] Patch for landing Clearing flags on attachment: 163980 Committed r128520: <http://trac.webkit.org/changeset/128520>
WebKit Review Bot
Comment 10 2012-09-13 16:01:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.