Bug 96537

Summary: Regression(r128338): Broke Windows build
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 96496    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2012-09-12 11:40:26 PDT
r128338 broke Apple-Win build:
9>..\InjectedBundle\TestRunner.cpp(337) : error C2057: expected constant expression
9>..\InjectedBundle\TestRunner.cpp(337) : error C2466: cannot allocate an array of constant size 0
9>..\InjectedBundle\TestRunner.cpp(337) : error C2133: 'jsStringsArray' : unknown size
Comment 1 Chris Dumez 2012-09-12 11:43:22 PDT
Created attachment 163663 [details]
Patch
Comment 2 Chris Dumez 2012-09-12 11:52:43 PDT
Created attachment 163665 [details]
Patch

Use OwnArrayPtr.
Comment 3 WebKit Review Bot 2012-09-12 12:25:30 PDT
Comment on attachment 163665 [details]
Patch

Clearing flags on attachment: 163665

Committed r128349: <http://trac.webkit.org/changeset/128349>
Comment 4 WebKit Review Bot 2012-09-12 12:25:34 PDT
All reviewed patches have been landed.  Closing bug.