Summary: | [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 96374, 96537 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Chris Dumez
2012-09-12 04:43:15 PDT
Created attachment 163589 [details]
Patch
Comment on attachment 163589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163589&action=review > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:333 > +static inline JSValueRef stringArrayToJS(JSContextRef context, WKArrayRef strings) I guess this is fine as it only works with strings. Otherwise maybe we should just be a toJS overload. Comment on attachment 163589 [details] Patch Rejecting attachment 163589 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: -queue/Source/WebKit/chromium/third_party/pyftpdlib/src --revision 977 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 43>At revision 977. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13827607 Created attachment 163651 [details]
Patch for landing
Could someone please cq+?
Comment on attachment 163651 [details] Patch for landing Clearing flags on attachment: 163651 Committed r128338: <http://trac.webkit.org/changeset/128338> All reviewed patches have been landed. Closing bug. |