Bug 96496

Summary:

[WK2][WKTR] TestRunner needs to implement originsWithApplicationCache

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, kenneth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

96374, 96537

Bug Blocks:

Attachments:

Description	Flags
Patch	kenneth: review+, webkit.review.bot: commit-queue-
Patch for landing	none

Chris Dumez

Reported 2012-09-12 04:43:15 PDT

TestRunner needs to implement originsWithApplicationCache(). This is needed by the following test case: http/tests/appcache/origins-with-appcache.html

Attachments
Patch (10.15 KB, patch) 2012-09-12 04:49 PDT, Chris Dumez	kenneth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch for landing (10.11 KB, patch) 2012-09-12 09:51 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2012-09-12 04:49:19 PDT

Created attachment 163589 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2012-09-12 05:13:00 PDT

Comment on attachment 163589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163589&action=review > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:333 > +static inline JSValueRef stringArrayToJS(JSContextRef context, WKArrayRef strings) I guess this is fine as it only works with strings. Otherwise maybe we should just be a toJS overload.

WebKit Review Bot

Comment 3 2012-09-12 05:33:07 PDT

Comment on attachment 163589 [details] Patch Rejecting attachment 163589 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: -queue/Source/WebKit/chromium/third_party/pyftpdlib/src --revision 977 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 43>At revision 977. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13827607

Chris Dumez

Comment 4 2012-09-12 09:51:53 PDT

Created attachment 163651 [details] Patch for landing Could someone please cq+?

WebKit Review Bot

Comment 5 2012-09-12 10:42:00 PDT

Comment on attachment 163651 [details] Patch for landing Clearing flags on attachment: 163651 Committed r128338: <http://trac.webkit.org/changeset/128338>

WebKit Review Bot

Comment 6 2012-09-12 10:42:04 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 7 2012-09-12 11:44:03 PDT

Apparently broke Apple-Win build. Addressing the issue in Bug 96537.

Note You need to log in before you can comment on or make changes to this bug.