Introduce SelectorCheckingEffects.

• Component: New Bugs
• Status: NEW ---

[Dimitri Glazkov (Google)]

Introduce StyleCheckingEffects.

[Dimitri Glazkov (Google)]

Created attachment 163472 [details]
Patch

[Dimitri Glazkov (Google)]

This

[Dimitri Glazkov (Google)]

This is based off the patch on bug 96425. Expect purple until it lands.

[Eric Seidel (no email)]

Comment on attachment 163472 [details]
Patch

Effects is kinda an odd name, but this looks fine.  I don't have any better suggestions. :)

[Antti Koivisto]

Comment on attachment 163472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163472&action=review

> Source/WebCore/css/SelectorChecker.h:80
> +    // Some information can't be determined until the selector checking runs.
> +    // This struct captures that information.
> +    struct SelectorCheckingEffects {

Name "Effects" doesn't make sense to me here. Wouldn't it be better to capture all return values (including SelectorMatch) to something like SelectorCheckResult?

r- for now.

[Dimitri Glazkov (Google)]

(In reply to comment #5)
> (From update of attachment 163472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163472&action=review
> 
> > Source/WebCore/css/SelectorChecker.h:80
> > +    // Some information can't be determined until the selector checking runs.
> > +    // This struct captures that information.
> > +    struct SelectorCheckingEffects {
> 
> Name "Effects" doesn't make sense to me here. Wouldn't it be better to capture all return values (including SelectorMatch) to something like SelectorCheckResult?

Yup. Sounds good.

> 
> r- for now.