| Summary: | Remove transient state regarding uknown pseudoelements from SelectorChecker. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, eric, macpherson, menard, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 96445 | ||||||||
| Bug Blocks: | 89879 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dimitri Glazkov (Google)
2012-09-11 14:29:35 PDT
Created attachment 163440 [details]
Patch
I wonder if I should add SelectorCheckingResult that's returned by checkSelector and stash stuff in there instead of using by-ref parameters. Comment on attachment 163440 [details]
Patch
I think this is going to end up as part of some sort of CheckRequest object, insetad of a separate bool :)
Comment on attachment 163440 [details]
Patch
But this is probably a step in teh right direction.
(In reply to comment #3) > (From update of attachment 163440 [details]) > I think this is going to end up as part of some sort of CheckRequest object, insetad of a separate bool :) CheckRequest or CheckResponse? Or maybe SelectorCheckingResults? They all sound good to me. :) Comment on attachment 163440 [details]
Patch
I will do this in the next patch.
Comment on attachment 163440 [details] Patch Rejecting attachment 163440 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: olved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13820554 Created attachment 163647 [details]
Patch for landing
Comment on attachment 163647 [details] Patch for landing Clearing flags on attachment: 163647 Committed r128329: <http://trac.webkit.org/changeset/128329> All reviewed patches have been landed. Closing bug. |