Bug 96366

Summary: [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit2Assignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, mikhail.pozdnyakov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-09-11 02:21:29 PDT
WebKitTestRunner needs testRunner.callShouldCloseOnWebView in order to unskip fast/events/onbeforeunload-focused-iframe.html
Attachments
Patch (6.23 KB, patch)
2012-09-11 07:36 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (6.08 KB, patch)
2012-09-12 01:44 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-09-11 07:31:31 PDT
*** Bug 96386 has been marked as a duplicate of this bug. ***
Sudarsana Nagineni (babu)
Comment 2 2012-09-11 07:36:11 PDT
Created attachment 163360 [details] Patch
Chris Dumez
Comment 3 2012-09-11 07:50:08 PDT
Comment on attachment 163360 [details] Patch LGTM.
Kenneth Rohde Christiansen
Comment 4 2012-09-11 09:07:38 PDT
Comment on attachment 163360 [details] Patch I am not sure about the naming, can you pass this by Anders Carlsson?
Sudarsana Nagineni (babu)
Comment 5 2012-09-11 09:19:03 PDT
(In reply to comment #4) > (From update of attachment 163360 [details]) > I am not sure about the naming, can you pass this by Anders Carlsson? Sure. I'll ping Anders about this.
Alexey Proskuryakov
Comment 6 2012-09-11 13:23:05 PDT
Comment on attachment 163360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163360&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h:80 > +WK_EXPORT bool WKBundleFrameCallShouldCloseOnWebView(WKBundleFrameRef frame); It's surprising to see this as API.
Sudarsana Nagineni (babu)
Comment 7 2012-09-12 01:44:06 PDT
Created attachment 163545 [details] Patch I moved this method to private now. Thanks for notifying, Alexey. The name is still same as it is in the test case.
Anders Carlsson
Comment 8 2012-09-13 12:15:47 PDT
Comment on attachment 163545 [details] Patch Looks good!
WebKit Review Bot
Comment 9 2012-09-13 12:25:49 PDT
Comment on attachment 163545 [details] Patch Clearing flags on attachment: 163545 Committed r128491: <http://trac.webkit.org/changeset/128491>
WebKit Review Bot
Comment 10 2012-09-13 12:25:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.