[WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView

• Component: WebKit2
• Status: RESOLVED FIXED

[Sudarsana Nagineni (babu)]

WebKitTestRunner needs testRunner.callShouldCloseOnWebView in order to unskip fast/events/onbeforeunload-focused-iframe.html

[Mikhail Pozdnyakov]

*** Bug 96386 has been marked as a duplicate of this bug. ***

[Sudarsana Nagineni (babu)]

Created attachment 163360 [details]
Patch

[Chris Dumez]

Comment on attachment 163360 [details]
Patch

LGTM.

[Kenneth Rohde Christiansen]

Comment on attachment 163360 [details]
Patch

I am not sure about the naming, can you pass this by Anders Carlsson?

[Sudarsana Nagineni (babu)]

(In reply to comment #4)
> (From update of attachment 163360 [details])
> I am not sure about the naming, can you pass this by Anders Carlsson?

Sure. I'll ping Anders about this.

[Alexey Proskuryakov]

Comment on attachment 163360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163360&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h:80
> +WK_EXPORT bool WKBundleFrameCallShouldCloseOnWebView(WKBundleFrameRef frame);

It's surprising to see this as API.

[Sudarsana Nagineni (babu)]

Created attachment 163545 [details]
Patch

I moved this method to private now. Thanks for notifying, Alexey. The name is still same as it is in the test case.

[Anders Carlsson]

Comment on attachment 163545 [details]
Patch

Looks good!

[WebKit Review Bot]

Comment on attachment 163545 [details]
Patch

Clearing flags on attachment: 163545

Committed r128491: <http://trac.webkit.org/changeset/128491>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.