Bug 95760

Summary: [CSS Shaders] Update custom filter tests to use the new security model
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: Layout and RenderingAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, dino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71392, 93871    
Attachments:
Description Flags
Patch
none
Patch none

Max Vujovic
Reported 2012-09-04 10:47:46 PDT
Currently, most of the custom filter tests sample the DOM element texture (u_texture) and write to gl_FragColor. Instead, the tests should not sample the DOM element texture and write to css_MixColor. This will enable us to remove direct DOM element texture access in bug 93871.
Attachments
Patch (319.32 KB, patch)
2012-09-04 16:22 PDT, Max Vujovic 		no flags
DetailsFormatted DiffDiff
Patch (319.60 KB, patch)
2012-09-05 00:13 PDT, Max Vujovic 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Max Vujovic
Comment 1 2012-09-04 16:22:27 PDT
Created attachment 162126 [details] Patch
Alexandru Chiculita
Comment 2 2012-09-04 17:02:19 PDT
Comment on attachment 162126 [details] Patch Looks good to me!
Max Vujovic
Comment 3 2012-09-05 00:13:39 PDT
Created attachment 162174 [details] Patch Updated chromium TestExpectations. Need baselines for cr-linux, cr-win.
Max Vujovic
Comment 4 2012-09-05 08:40:48 PDT
Comment on attachment 162174 [details] Patch Bots look good. Setting r?, cq?.
WebKit Review Bot
Comment 5 2012-09-05 11:26:37 PDT
Comment on attachment 162174 [details] Patch Clearing flags on attachment: 162174 Committed r127615: <http://trac.webkit.org/changeset/127615>
WebKit Review Bot
Comment 6 2012-09-05 11:26:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.