Bug 95596

Summary: [chromium] Add main versus impl thread asserts
Product: WebKit Reporter: Christopher Cameron <ccameron>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, danakj, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Christopher Cameron
Reported 2012-08-31 11:47:16 PDT
[chromium] Add main versus impl thread asserts
Attachments
Patch (51.82 KB, patch)
2012-08-31 11:50 PDT, Christopher Cameron 		no flags
DetailsFormatted DiffDiff
Patch (51.86 KB, patch)
2012-08-31 13:35 PDT, Christopher Cameron 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Christopher Cameron
Comment 1 2012-08-31 11:50:55 PDT
Created attachment 161745 [details] Patch
Christopher Cameron
Comment 2 2012-08-31 12:07:21 PDT
PTAL, this is a subset of bug 95057 (since that was getting unwieldy).
James Robinson
Comment 3 2012-08-31 12:21:04 PDT
Comment on attachment 161745 [details] Patch R=me
WebKit Review Bot
Comment 4 2012-08-31 12:22:37 PDT
Comment on attachment 161745 [details] Patch Rejecting attachment 161745 [details] from commit-queue. ccameron@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Dana Jansens
Comment 5 2012-08-31 12:26:37 PDT
Comment on attachment 161745 [details] Patch You can set CQ? but not CQ+ until you're a committer, as the bot has said :)
WebKit Review Bot
Comment 6 2012-08-31 12:55:06 PDT
Comment on attachment 161745 [details] Patch Rejecting attachment 161745 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13720300
Dana Jansens
Comment 7 2012-08-31 12:56:51 PDT
Second time I've seen that happen for now even though it has R+. Must be a bug in the bot. :\
James Robinson
Comment 8 2012-08-31 13:27:53 PDT
Comment on attachment 161745 [details] Patch it's not a bug in the bot, WebCore/ChangeLog doesn't have a "Reviewed by NOBODY (OOPS!)." line in it. Add it back and the queue will accept it
Christopher Cameron
Comment 9 2012-08-31 13:35:05 PDT
Created attachment 161759 [details] Patch
Christopher Cameron
Comment 10 2012-08-31 13:35:35 PDT
Ah, thanks. Fixed.
WebKit Review Bot
Comment 11 2012-08-31 14:11:00 PDT
Comment on attachment 161759 [details] Patch Clearing flags on attachment: 161759 Committed r127317: <http://trac.webkit.org/changeset/127317>
WebKit Review Bot
Comment 12 2012-08-31 14:11:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.