Bug 95573

Summary:

[chromium] WebGestureEvent deltaX/deltaY fields are overloaded

Product:

WebKit

Reporter:

Rick Byers <rbyers>

Component:

Platform

Assignee:

Rick Byers <rbyers>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, jamesr, rjkroege, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

93123, 95496

Attachments:

Description	Flags
Patch	none
Update bug number in ChangeLog	none
jamesr cr feedback	none
Update ChangeLog with chromium CL numbers	none

Rick Byers

Reported 2012-08-31 08:06:26 PDT

Split out from bug 93123 which covers PlatformGestureEvent. First I'll fix chromium's WebGestureEvent.

Attachments
Patch (16.69 KB, patch) 2012-08-31 09:42 PDT, Rick Byers	no flags	Details Formatted Diff Diff
Update bug number in ChangeLog (16.69 KB, patch) 2012-09-04 07:10 PDT, Rick Byers	no flags	Details Formatted Diff Diff
jamesr cr feedback (16.68 KB, patch) 2012-09-04 09:17 PDT, Rick Byers	no flags	Details Formatted Diff Diff
Update ChangeLog with chromium CL numbers (16.62 KB, patch) 2012-09-05 11:07 PDT, Rick Byers	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Rick Byers

Comment 1 2012-08-31 09:42:15 PDT

Created attachment 161721 [details] Patch

Rick Byers

Comment 2 2012-09-04 06:48:18 PDT

Comment on attachment 161721 [details] Patch I can't land this until http://codereview.chromium.org/10895024/ lands, but other than updating the ChangeLog with the right chromium revision number, I don't have any other changes planned so we might as well start reviewing this now.

Rick Byers

Comment 3 2012-09-04 07:10:18 PDT

Created attachment 162037 [details] Update bug number in ChangeLog

James Robinson

Comment 4 2012-09-04 09:00:35 PDT

Comment on attachment 162037 [details] Update bug number in ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review > Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159 > + event.data.scrollUpdate.deltaX = > + static_cast<float>(arguments[0].toDouble()); > + event.data.scrollUpdate.deltaY = > + static_cast<float>(arguments[1].toDouble()); no need to line wrap - this is WebKit > Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1178 > + event.data.tap.tapCount = > + static_cast<float>(arguments[2].toDouble()); no line wrapping here > Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1240 > + event.data.flingStart.velocityX = > + static_cast<float>(arguments[2].toDouble()); > + event.data.flingStart.velocityY = > + static_cast<float>(arguments[3].toDouble()); same

Rick Byers

Comment 5 2012-09-04 09:13:50 PDT

Comment on attachment 162037 [details] Update bug number in ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review >> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159 >> + static_cast<float>(arguments[1].toDouble()); > > no need to line wrap - this is WebKit Thanks. Going back and forth on this 6-way handshake isn't making it any easier for me to get use to WebKit style vs. chromium style ;-)

Rick Byers

Comment 6 2012-09-04 09:17:18 PDT

Created attachment 162050 [details] jamesr cr feedback

James Robinson

Comment 7 2012-09-04 10:16:50 PDT

Comment on attachment 162050 [details] jamesr cr feedback Looks good, although we can't land yet.

Rick Byers

Comment 8 2012-09-05 11:07:53 PDT

Created attachment 162290 [details] Update ChangeLog with chromium CL numbers

Rick Byers

Comment 9 2012-09-05 11:18:35 PDT

Thanks James!

WebKit Review Bot

Comment 10 2012-09-05 21:46:16 PDT

Comment on attachment 162290 [details] Update ChangeLog with chromium CL numbers Clearing flags on attachment: 162290 Committed r127689: <http://trac.webkit.org/changeset/127689>

WebKit Review Bot

Comment 11 2012-09-05 21:46:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.