Summary: | [chromium] WebGestureEvent deltaX/deltaY fields are overloaded | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rick Byers <rbyers> | ||||||||||
Component: | Platform | Assignee: | Rick Byers <rbyers> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, jamesr, rjkroege, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 93123, 95496 | ||||||||||||
Attachments: |
|
Description
Rick Byers
2012-08-31 08:06:26 PDT
Created attachment 161721 [details]
Patch
Comment on attachment 161721 [details] Patch I can't land this until http://codereview.chromium.org/10895024/ lands, but other than updating the ChangeLog with the right chromium revision number, I don't have any other changes planned so we might as well start reviewing this now. Created attachment 162037 [details]
Update bug number in ChangeLog
Comment on attachment 162037 [details] Update bug number in ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review > Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159 > + event.data.scrollUpdate.deltaX = > + static_cast<float>(arguments[0].toDouble()); > + event.data.scrollUpdate.deltaY = > + static_cast<float>(arguments[1].toDouble()); no need to line wrap - this is WebKit > Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1178 > + event.data.tap.tapCount = > + static_cast<float>(arguments[2].toDouble()); no line wrapping here > Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1240 > + event.data.flingStart.velocityX = > + static_cast<float>(arguments[2].toDouble()); > + event.data.flingStart.velocityY = > + static_cast<float>(arguments[3].toDouble()); same Comment on attachment 162037 [details] Update bug number in ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review >> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159 >> + static_cast<float>(arguments[1].toDouble()); > > no need to line wrap - this is WebKit Thanks. Going back and forth on this 6-way handshake isn't making it any easier for me to get use to WebKit style vs. chromium style ;-) Created attachment 162050 [details]
jamesr cr feedback
Comment on attachment 162050 [details]
jamesr cr feedback
Looks good, although we can't land yet.
Created attachment 162290 [details]
Update ChangeLog with chromium CL numbers
Thanks James! Comment on attachment 162290 [details] Update ChangeLog with chromium CL numbers Clearing flags on attachment: 162290 Committed r127689: <http://trac.webkit.org/changeset/127689> All reviewed patches have been landed. Closing bug. |