Bug 95408

Summary: [EFL][WK2] Replace PageClientImpl with ewk view in constructor of EflViewportHandler.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 95342    
Attachments:
Description Flags
patch
none
patch none

Kangil Han
Reported 2012-08-29 17:32:21 PDT
It could be replaced by ewk view.
Attachments
patch (4.61 KB, patch)
2012-08-29 18:12 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
patch (4.64 KB, patch)
2012-08-29 21:10 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-08-29 18:12:26 PDT
Created attachment 161380 [details] patch
Ryuan Choi
Comment 2 2012-08-29 19:52:38 PDT
Comment on attachment 161380 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=161380&action=review > Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:-43 > - ASSERT(m_pageClientImpl); Good to me. As a nit, we can check m_viewWidget instead of m_pageClientImpl.
Kangil Han
Comment 3 2012-08-29 21:10:36 PDT
Created attachment 161394 [details] patch Done!
Gyuyoung Kim
Comment 4 2012-08-29 21:21:13 PDT
Comment on attachment 161394 [details] patch LGTM.
WebKit Review Bot
Comment 5 2012-08-29 22:45:13 PDT
Comment on attachment 161394 [details] patch Clearing flags on attachment: 161394 Committed r127102: <http://trac.webkit.org/changeset/127102>
WebKit Review Bot
Comment 6 2012-08-29 22:45:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.