Bug 95297 – [EFL] EFL port should turn on ENCRYPTED_MEDIA

• Component: WebKit EFL
• Status: RESOLVED WONTFIX

[Chris Dumez]

EFL port does not current enable ENCRYPTED_MEDIA.

It is covered by:
media/encrypted-media/
fast/events/constructors/media-key-event-constructor.html

[Éva Balázsfalvi]

Created attachment 240266 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 240266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240266&action=review

> LayoutTests/platform/efl/TestExpectations:1119
> +# These tests are for an obsolete version of the EME spec.

I think you have to place these failing tests in  TESTS EXPECTED TO FAIL area. Here is for tests which needs to be investigated.

[Csaba Osztrogonác]

Comment on attachment 240266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240266&action=review

> LayoutTests/platform/efl/TestExpectations:1117
> +webkit.org/b/95297 media/encrypted-media [ Pass ]
> +webkit.org/b/95297 fast/events/constructors/media-key-event-constructor.html [ Pass ]

Please remove these lines instead of marking them as [ Pass ].

>> LayoutTests/platform/efl/TestExpectations:1119
>> +# These tests are for an obsolete version of the EME spec.
> 
> I think you have to place these failing tests in  TESTS EXPECTED TO FAIL area. Here is for tests which needs to be investigated.

Agree.

[Philippe Normand]

What's the point of enabling this non-working feature?

[Éva Balázsfalvi]

I accidentally turned on ENCRYPTED_MEDIA in OptionsEfl.cmake, didn't mean to leave it in the code.

I only wanted to unskip the passing ENCRYPTED_MEDIA_V2 tests after r170910.

Since my patch is not really doing what is requested in this bug report, I created a new, more fitting bug report for it: https://bugs.webkit.org/show_bug.cgi?id=138133

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.