Bug 94898

Summary: [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95055    
Bug Blocks: 94664    
Attachments:
Description Flags
Patch 1
none
Patch 2 none

Dominic Cooney
Reported 2012-08-23 22:26:40 PDT
The following test: fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html started failing on Win7 at r126534 according to the flakiness dashboard: <http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Ftime-multiple-fields%2Ftime-multiple-fields-appearance-pseudo-elements.html> It looks like the image results differ in the seconds field – the expectation is :56, but the actual has :00 seconds.
Attachments
Patch 1 (2.26 KB, patch)
2012-08-23 22:45 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (2.26 KB, patch)
2012-08-23 22:49 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-23 22:45:41 PDT
Created attachment 160331 [details] Patch 1
yosin
Comment 2 2012-08-23 22:46:10 PDT
Comment on attachment 160331 [details] Patch 1 Could you review this patch? Thanks in advance.
Dominic Cooney
Comment 3 2012-08-23 22:48:33 PDT
I assume this will need rebaselining?
Kent Tamura
Comment 4 2012-08-23 22:48:35 PDT
Comment on attachment 160331 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=160331&action=review > LayoutTests/ChangeLog:2 > +2012-08-23 Yoshifumi Inoue <yosin@chromium.org> > + [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7 Need a blank line before the description line.
yosin
Comment 5 2012-08-23 22:49:17 PDT
Created attachment 160332 [details] Patch 2
yosin
Comment 6 2012-08-23 22:50:14 PDT
Comment on attachment 160332 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Update ChangeLong
Kent Tamura
Comment 7 2012-08-23 23:07:44 PDT
Comment on attachment 160332 [details] Patch 2 ok
yosin
Comment 8 2012-08-23 23:09:52 PDT
Comment on attachment 160332 [details] Patch 2 Clearing flags on attachment: 160332 Committed r126545: <http://trac.webkit.org/changeset/126545>
yosin
Comment 9 2012-08-23 23:09:56 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 10 2012-08-23 23:16:22 PDT
(In reply to comment #3) > I assume this will need rebaselining? No. This patch has updated an expectation.
Julien Chaffraix
Comment 11 2012-08-24 10:41:20 PDT
This patch still didn't solve the issue and I re-disabled the tests & filed a follow-up bug (bug 94951) about it.
Note You need to log in before you can comment on or make changes to this bug.