Bug 94799

Summary:

Web Inspector: [WebGL] Implement custom wrap functions on GL context

Product:

WebKit

Reporter:

Andrey Adaikin <aandrey>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Adaikin <aandrey>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	pfeldman: review+
Patch to land	none

Andrey Adaikin

Reported 2012-08-23 05:00:19 PDT

Yet another step towards WebGL instrumentation.

Attachments
Patch (14.55 KB, patch) 2012-08-23 05:04 PDT, Andrey Adaikin	pfeldman: review+	Details Formatted Diff Diff
Patch to land (14.58 KB, patch) 2012-08-24 05:14 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrey Adaikin

Comment 1 2012-08-23 05:04:36 PDT

Pavel Feldman

Comment 2 2012-08-24 04:39:15 PDT

Comment on attachment 160132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review > Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884 > + "createBuffer": WebGLBufferResource, I would implement this as array of pairs (arrays) so that you did not need to use Object.keys.

Andrey Adaikin

Comment 3 2012-08-24 05:13:48 PDT

Comment on attachment 160132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160132&action=review >> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:884 >> + "createBuffer": WebGLBufferResource, > > I would implement this as array of pairs (arrays) so that you did not need to use Object.keys. done.

Andrey Adaikin

Comment 4 2012-08-24 05:14:26 PDT

Andrey Kosyakov

Comment 5 2012-08-24 05:23:49 PDT

Note You need to log in before you can comment on or make changes to this bug.