Bug 94481 – [Chromium] Remove WebKitPlatformSupport::sharedWorkerRepository

• Component: WebKit Misc.
• Status: RESOLVED DUPLICATE

[Mark Pilgrim (Google)]

[Chromium] Remove WebKitPlatformSupport::sharedWorkerRepository

[Mark Pilgrim (Google)]

Created attachment 159425 [details]
WIP Incomplete Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Mark Pilgrim (Google)]

Comment on attachment 159425 [details]
WIP Incomplete Patch

This patch is incomplete. I need to find where Chromium implements WebKitPlatformSupport::sharedWorkerRepository() so I can remove that function, then find where Chromium calls WebKit::initialize() so I can add the call to SharedWorkerRepository::setSharedWorkerRepository.

Other comments welcome too.

[Peter Beverloo (cr-android ews)]

Comment on attachment 159425 [details]
WIP Incomplete Patch

Attachment 159425 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13539602

[WebKit Review Bot]

Comment on attachment 159425 [details]
WIP Incomplete Patch

Attachment 159425 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13543350

[Adam Barth]

Comment on attachment 159425 [details]
WIP Incomplete Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159425&action=review

> Source/WebCore/workers/SharedWorkerRepository.h:67
> +        // sets global shared worker repository
> +        static void setSharedWorkerRepository(WebKit::WebSharedWorkerRepository*);

We shouldn't have code in that references Chromium API types outside of Chromium-specific regions of the code.  Do we need a SharedWorkerRepositoryChromium.h to house this static method?

I didn't find anyone who calls this function, so I'm not sure what to recommend.  Do you plan to keep the implementation in Source/WebKit/chromium/src/SharedWorkerRepository.cpp ?  If so, it might make sense to put the header for this function in Source/WebKit/chromium/src.

[Adam Barth]

Comment on attachment 159425 [details]
WIP Incomplete Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159425&action=review

> Source/WebKit/chromium/src/SharedWorkerRepository.cpp:197
>  bool SharedWorkerRepository::isAvailable()

Note: In the long term, we don't want to have "namespace WebCore" code in WebKit because it will prevent us from splitting WebCore.dll from WebKit.dll.

[Adam Barth]

> then find where Chromium calls WebKit::initialize()

WebKit::initialize is in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/WebKit.cpp#L102

[Mark Pilgrim (Google)]

*** This bug has been marked as a duplicate of bug 95861 ***