Bug 94435

Summary: [GTK] Split WebCore/platform into a separate library
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, halton.huo, laney, mrobinson, pnormand, pochu27, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Kov's patch mrobinson: review+

Gustavo Noronha (kov)
Reported 2012-08-19 15:30:39 PDT
[GTK] Split WebCore/platform into a separate library
Attachments
Patch (87.72 KB, patch)
2012-08-19 15:37 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Kov's patch (91.16 KB, patch)
2012-11-15 02:22 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2012-08-19 15:37:39 PDT
Created attachment 159309 [details] Patch
Martin Robinson
Comment 2 2012-08-20 10:37:24 PDT
Comment on attachment 159309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159309&action=review > Source/WebCore/GNUmakefile.am:1055 > + -DBUILDING_WEBKIT \ > + $(global_cppflags) \ > + $(webcore_cppflags) \ > + $(webcoregtk_cppflags) \ > + $(javascriptcore_cppflags) \ > + -fno-strict-aliasing \ > + $(CAIRO_CFLAGS) \ > + $(CLUTTER_CFLAGS) \ > + $(COVERAGE_CFLAGS) \ > + $(ENCHANT_CFLAGS) \ > + $(GAMEPAD_CFLAGS) \ > + $(GEOCLUE_CFLAGS) \ > + $(GLIB_CFLAGS) \ > + $(GSTREAMER_CFLAGS) \ > + $(LIBSOUP_CFLAGS) \ > + $(LIBXML_CFLAGS) \ > + $(LIBXSLT_CFLAGS) \ > + $(PANGO_CFLAGS) \ > + $(SQLITE3_CFLAGS) \ > + $(UNICODE_CFLAGS) \ > + $(XRENDER_CFLAGS) \ > + $(XT_CFLAGS) Perhaps we should abstract this away into a variable for use by all WebCore libraries?
Gustavo Noronha (kov)
Comment 3 2012-08-22 08:47:33 PDT
Committed r126306: <http://trac.webkit.org/changeset/126306>
Carlos Garcia Campos
Comment 4 2012-08-23 06:36:10 PDT
Reopening, this was rolled out, see: https://bugs.webkit.org/show_bug.cgi?id=94797
Philippe Normand
Comment 5 2012-11-15 02:22:08 PST
Created attachment 174377 [details] Kov's patch
Philippe Normand
Comment 6 2012-11-15 02:23:40 PST
I just rebased the patch against ToT. Worked fine here, minibrowser with flash plugin.
Carlos Garcia Campos
Comment 7 2012-11-15 02:24:59 PST
I'll try it out again, thanks!
Carlos Garcia Campos
Comment 8 2012-11-15 03:41:27 PST
(In reply to comment #7) > I'll try it out again, thanks! Works for me too!
Gustavo Noronha (kov)
Comment 9 2012-11-15 17:06:34 PST
Committed r134864: <http://trac.webkit.org/changeset/134864>
Halton Huo
Comment 10 2012-12-11 18:48:09 PST
*** Bug 101310 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.