Bug 94396

Summary: nrwt: don't fail tests if ImageDiff fails on the wk2 ports
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, beidson, ojan, rniwa, simon.fraser, thorton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94540    
Attachments:
Description Flags
Patch
beidson: review-
fix typoed bug # in comment rniwa: review+

Dirk Pranke
Reported 2012-08-17 16:57:23 PDT
nrwt: don't fail tests if ImageDiff fails on the wk2 ports
Attachments
Patch (2.30 KB, patch)
2012-08-17 17:00 PDT, Dirk Pranke 		beidson: review-
DetailsFormatted DiffDiff
fix typoed bug # in comment (2.14 KB, patch)
2012-08-17 17:21 PDT, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-08-17 17:00:31 PDT
Created attachment 159229 [details] Patch
Brady Eidson
Comment 2 2012-08-17 17:12:46 PDT
Comment on attachment 159229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159229&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:270 > + # https://bugs.webkit.org/show_bug.cgi?id=819262; ImageDiff doesn't Wrong bug id here.
Dirk Pranke
Comment 3 2012-08-17 17:21:18 PDT
Created attachment 159238 [details] fix typoed bug # in comment
Dirk Pranke
Comment 4 2012-08-17 17:26:02 PDT
Committed r125954: <http://trac.webkit.org/changeset/125954>
Simon Fraser (smfr)
Comment 5 2012-08-20 11:20:35 PDT
But why are we running ImageDiff at all on the Mac ports, other than for ref tests?
Dirk Pranke
Comment 6 2012-08-20 11:25:33 PDT
(In reply to comment #5) > But why are we running ImageDiff at all on the Mac ports, other than for ref tests? You're not; these are ref tests that are failing.
Note You need to log in before you can comment on or make changes to this bug.