Summary: | nrwt: don't fail tests if ImageDiff fails on the wk2 ports | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, beidson, ojan, rniwa, simon.fraser, thorton, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 94540 | ||||||||
Attachments: |
|
Description
Dirk Pranke
2012-08-17 16:57:23 PDT
Created attachment 159229 [details]
Patch
Comment on attachment 159229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159229&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:270 > + # https://bugs.webkit.org/show_bug.cgi?id=819262; ImageDiff doesn't Wrong bug id here. Created attachment 159238 [details]
fix typoed bug # in comment
Committed r125954: <http://trac.webkit.org/changeset/125954> But why are we running ImageDiff at all on the Mac ports, other than for ref tests? (In reply to comment #5) > But why are we running ImageDiff at all on the Mac ports, other than for ref tests? You're not; these are ref tests that are failing. |