Bug 93940

Summary:

Web Inspector: Add delete button to FileSystemView

Product:

WebKit

Reporter:

Taiju Tsuiki <tzik>

Component:

Web Inspector (Deprecated)

Assignee:

Taiju Tsuiki <tzik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, kinuko, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

91831, 94071

Bug Blocks:

68203

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	vsevik: review+, webkit.review.bot: commit-queue-

Taiju Tsuiki

Reported 2012-08-14 01:08:28 PDT

Adding a status bar button to allow user to delete an entry.

Attachments
Patch (12.85 KB, patch) 2012-08-15 00:33 PDT, Taiju Tsuiki	no flags	Details Formatted Diff Diff
Patch (11.97 KB, patch) 2012-08-22 20:11 PDT, Taiju Tsuiki	no flags	Details Formatted Diff Diff
Patch (13.47 KB, patch) 2012-08-26 21:24 PDT, Taiju Tsuiki	vsevik: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Taiju Tsuiki

Comment 1 2012-08-15 00:33:06 PDT

Created attachment 158517 [details] Patch

Taiju Tsuiki

Comment 2 2012-08-22 20:11:13 PDT

Created attachment 160074 [details] Patch

Vsevolod Vlasov

Comment 3 2012-08-25 02:54:33 PDT

Comment on attachment 160074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160074&action=review > Source/WebCore/inspector/front-end/FileSystemModel.js:277 > + if (errorCode === 0) if (!errorCode) > Source/WebCore/inspector/front-end/FileSystemModel.js:289 > + if (this._fileSystemsForOrigin[origin] && New line is not needed here.

Taiju Tsuiki

Comment 4 2012-08-26 21:24:25 PDT

Created attachment 160625 [details] Patch

WebKit Review Bot

Comment 5 2012-08-27 12:26:51 PDT

Comment on attachment 160625 [details] Patch Rejecting attachment 160625 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13618303

Taiju Tsuiki

Comment 6 2012-08-27 23:30:56 PDT

Comment on attachment 160074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160074&action=review Thanks! >> Source/WebCore/inspector/front-end/FileSystemModel.js:277 >> + if (errorCode === 0) > > if (!errorCode) Done >> Source/WebCore/inspector/front-end/FileSystemModel.js:289 >> + if (this._fileSystemsForOrigin[origin] && > > New line is not needed here. Done

Kinuko Yasuda

Comment 7 2012-08-27 23:42:13 PDT

Committed r126847: <http://trac.webkit.org/changeset/126847>

Note You need to log in before you can comment on or make changes to this bug.