RESOLVED FIXED 94071
Add deleteFileSystem support to DumpRenderTree for chromium
https://bugs.webkit.org/show_bug.cgi?id=94071
Summary Add deleteFileSystem support to DumpRenderTree for chromium
Taiju Tsuiki
Reported 2012-08-14 23:19:12 PDT
I need LocalFileSystem::deleteFileSystem support of DumpRenderTree to test Inspector. Can I wire it up like this?
Attachments
Patch (2.74 KB, patch)
2012-08-14 23:26 PDT, Taiju Tsuiki
no flags
Taiju Tsuiki
Comment 1 2012-08-14 23:26:19 PDT
Kinuko Yasuda
Comment 2 2012-08-14 23:28:58 PDT
Looks good to me.
WebKit Review Bot
Comment 3 2012-08-14 23:40:11 PDT
Comment on attachment 158507 [details] Patch Attachment 158507 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13501537
Kinuko Yasuda
Comment 4 2012-08-15 00:20:25 PDT
(In reply to comment #3) > (From update of attachment 158507 [details]) > Attachment 158507 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13501537 You'll need to roll chromium DEPS to get it compiling (after your change's in in chrome side).
Peter Beverloo (cr-android ews)
Comment 5 2012-08-15 08:49:54 PDT
Comment on attachment 158507 [details] Patch Attachment 158507 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13501687
Taiju Tsuiki
Comment 6 2012-08-15 23:23:41 PDT
Comment on attachment 158507 [details] Patch Chromium side change and its roll have landed. Kent-san, could you take a look?
Kent Tamura
Comment 7 2012-08-15 23:25:33 PDT
Comment on attachment 158507 [details] Patch ok
WebKit Review Bot
Comment 8 2012-08-16 00:54:51 PDT
Comment on attachment 158507 [details] Patch Clearing flags on attachment: 158507 Committed r125755: <http://trac.webkit.org/changeset/125755>
WebKit Review Bot
Comment 9 2012-08-16 00:54:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.