| Summary: | [V8] Remove unused methods from V8Binding.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 93095 | ||||||
| Attachments: |
|
||||||
|
Description
Kentaro Hara
2012-08-13 06:31:10 PDT
Created attachment 157980 [details]
Patch
Comment on attachment 157980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review > Source/WebCore/bindings/v8/V8Binding.h:-398 > - inline v8::Handle<v8::String> v8UndetectableString(const String& str) > - { > - return v8::String::NewUndetectable(fromWebCoreString(str), str.length()); > - } I'm surprised this isn't used by document.all. Maybe that uses another mechanism now? Committed r125492: <http://trac.webkit.org/changeset/125492> Comment on attachment 157980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157980&action=review >> Source/WebCore/bindings/v8/V8Binding.h:-398 >> - } > > I'm surprised this isn't used by document.all. Maybe that uses another mechanism now? It's realized by forcibly setting properties on 'this' object. (i.e. info.This()->ForceSet(name, value)) http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp&exact_package=chromium&q=v8htmldocumentcustom.cpp&type=cs&l=184 |