Bug 93616

Summary: Moving the common code from CodegeneratorJS/V8.pm to Codegenerator.pm
Product: WebKit Reporter: Vineet Chaudhary (vineetc) <code.vineet>
Component: New BugsAssignee: Vineet Chaudhary (vineetc) <code.vineet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Vineet Chaudhary (vineetc)
Reported 2012-08-09 08:57:56 PDT
IsArrayType() IsConstructorTemplate() IsTypedArrayType() these methods has the common implementaion for both V8 and JS and can be moved to common place Codegenerator.pm. This will also help to have checks in CodegeneratorCPP/ObjC/GObject.pm. Ref. Bug93613
Attachments
patch (15.59 KB, patch)
2012-08-09 08:59 PDT, Vineet Chaudhary (vineetc) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vineet Chaudhary (vineetc)
Comment 1 2012-08-09 08:59:15 PDT
Created attachment 157461 [details] patch
Adam Barth
Comment 2 2012-08-09 10:58:05 PDT
Comment on attachment 157461 [details] patch Ok.
Vineet Chaudhary (vineetc)
Comment 3 2012-08-09 23:31:15 PDT
Comment on attachment 157461 [details] patch Thanks :)
WebKit Review Bot
Comment 4 2012-08-10 01:46:53 PDT
Comment on attachment 157461 [details] patch Clearing flags on attachment: 157461 Committed r125261: <http://trac.webkit.org/changeset/125261>
WebKit Review Bot
Comment 5 2012-08-10 01:46:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.