Bug 93382

Summary: Rewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebCore JavaScriptAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, gyuyoung.kim, ossy, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93654    
Bug Blocks: 75793, 93407    
Attachments:
Description Flags
Patch
none
Patch
none
hopefully builds on EFL now eric: review+

Description Adam Barth 2012-08-07 12:17:21 PDT
Rewire the same-origin checks for the JavaScriptCore bindings through BindingSecurity
Comment 1 Adam Barth 2012-08-07 12:23:48 PDT
Created attachment 156972 [details]
Patch
Comment 2 Adam Barth 2012-08-07 12:25:09 PDT
Created attachment 156973 [details]
Patch
Comment 3 Gyuyoung Kim 2012-08-07 12:47:02 PDT
Comment on attachment 156973 [details]
Patch

Attachment 156973 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13445851
Comment 4 Adam Barth 2012-08-07 13:30:43 PDT
Created attachment 156989 [details]
hopefully builds on EFL now
Comment 5 Eric Seidel (no email) 2012-08-07 13:52:08 PDT
Comment on attachment 156989 [details]
hopefully builds on EFL now

I wonder what, if any, perf affect this has on DOM benchmarks.
Comment 6 Adam Barth 2012-08-07 14:03:29 PDT
> I wonder what, if any, perf affect this has on DOM benchmarks.

I'll run the perf tests before landing, but I don't expect any trouble.
Comment 7 Adam Barth 2012-08-07 16:12:17 PDT
The work to rewrite allowsAccessFrom through BindingSecurity is in Bug 93407.
Comment 8 Sam Weinig 2012-08-07 17:25:39 PDT
This seems OK to me, but I would like to see the extra indirect go away.  A follow up patch would be fine for that.
Comment 9 Adam Barth 2012-08-07 22:24:33 PDT
Thanks.  Will do.
Comment 10 Adam Barth 2012-08-08 17:41:09 PDT
Committed r125126: <http://trac.webkit.org/changeset/125126>
Comment 11 Csaba Osztrogonác 2012-08-09 14:15:53 PDT
(In reply to comment #10)
> Committed r125126: <http://trac.webkit.org/changeset/125126>

It caused an assertion on Qt and on GTK. Could you check it, please? https://bugs.webkit.org/show_bug.cgi?id=93654
Comment 12 Adam Barth 2012-08-09 14:23:17 PDT
> It caused an assertion on Qt and on GTK. Could you check it, please? https://bugs.webkit.org/show_bug.cgi?id=93654

Certainly.