Summary: | [V8] Move setIsolatedWorldSecurityOrigin() from V8Proxy to ScriptController | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 93095 | ||||||
Attachments: |
|
Description
Kentaro Hara
2012-08-06 21:54:19 PDT
Created attachment 156861 [details]
Patch
Comment on attachment 156861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156861&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:183 > void ScriptController::setIsolatedWorldSecurityOrigin(int worldID, PassRefPtr<SecurityOrigin> securityOrigin) A better name for this function is something like setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming crazy in this patch. (In reply to comment #2) > A better name for this function is something like setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming crazy in this patch. This method is exposed to the Chromium WebKit API. If we want to rename it, we should rename the API name too. If you want, I'll do it. WDYT? http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h&exact_package=chromium&q=setIsolatedWorldSecurityOrigin&type=cs&l=258 Either way let me land this patch first. Comment on attachment 156861 [details] Patch Clearing flags on attachment: 156861 Committed r124962: <http://trac.webkit.org/changeset/124962> All reviewed patches have been landed. Closing bug. It's probably too much work to rename the API. OK, then let's keep it as is. |