Bug 93227

Summary:

Chromium-Mac: Use the default locale only if the browser locale matches to it

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Platform

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

morrita

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	morrita: review+

Description Kent Tamura 2012-08-05 23:26:35 PDT

OSX version of Bug 93083.

Comment 1 Kent Tamura 2012-08-06 00:05:34 PDT

Created attachment 156609 [details]
Patch

Comment 2 Kent Tamura 2012-08-06 02:48:54 PDT

Update the summary to avoid unexpected Gmail threading.

Comment 3 Hajime Morrita 2012-08-06 18:50:43 PDT

Comment on attachment 156609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review

> Source/WebCore/platform/text/mac/LocaleMac.mm:92
> +    String browserLanguage = languageFromLocale(defaultLanguage());

Passing defulat"Language" to languageFrom"Locale"(). is this right?

Comment 4 Kent Tamura 2012-08-06 18:56:21 PDT

Comment on attachment 156609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review

>> Source/WebCore/platform/text/mac/LocaleMac.mm:92
>> +    String browserLanguage = languageFromLocale(defaultLanguage());
> 
> Passing defulat"Language" to languageFrom"Locale"(). is this right?

Unfortunately, it's right.  defaultLanguage() returns a locale identifier like "en-US" as well as a language identifier like "en".

Comment 5 Kent Tamura 2012-08-06 19:01:43 PDT

Committed r124834: <http://trac.webkit.org/changeset/124834>