Bug 93217

Summary: [V8] Replace v8::Undefined() in custom bindings with v8Undefined()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 93095    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-08-05 18:33:38 PDT
We should use v8Undefined() everywhere in V8 bindings.
Attachments
Patch (63.04 KB, patch)
2012-08-05 18:34 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (63.07 KB, patch)
2012-08-07 17:56 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-05 18:34:56 PDT
Created attachment 156581 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-07 15:22:07 PDT
Comment on attachment 156581 [details] Patch OK. LGTM.
WebKit Review Bot
Comment 3 2012-08-07 16:01:31 PDT
Comment on attachment 156581 [details] Patch Rejecting attachment 156581 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: v8/custom/V8WebGLRenderingContextCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13446868
Kentaro Hara
Comment 4 2012-08-07 17:56:40 PDT
Created attachment 157062 [details] patch for landing
Kentaro Hara
Comment 5 2012-08-07 17:57:45 PDT
Let me wait for landing the patch until we complete the discussion in bug 93218.
Kentaro Hara
Comment 6 2012-08-09 01:47:59 PDT
(In reply to comment #5) > Let me wait for landing the patch until we complete the discussion in bug 93218. Per discussion in bug 93218, we decided to use v8Undefined(Isolate* isolate=0) instead of v8Undefined(). Marking WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.