Summary: | [V8] Replace v8::Handle<v8::Value>() in custom bindings with v8Undefined() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 93095 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-08-05 18:22:43 PDT
Created attachment 156580 [details]
Patch
Comment on attachment 156580 [details]
Patch
LGTM.
Comment on attachment 156580 [details] Patch Rejecting attachment 156580 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13449601 Created attachment 157056 [details]
patch for landing
Comment on attachment 157056 [details] patch for landing Clearing flags on attachment: 157056 Committed r124984: <http://trac.webkit.org/changeset/124984> |