Summary: | [Chromium-win] Use the default locale only if the browser locale matches to it | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Platform | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | morrita | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 93085 | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-08-03 03:09:06 PDT
Created attachment 156305 [details]
Patch
Comment on attachment 156305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156305&action=review > Source/WebCore/platform/text/LocaleWin.cpp:81 > - static LocaleWin* currentLocale = LocaleWin::create(LOCALE_USER_DEFAULT).leakPtr(); > + static LocaleWin* currentLocale; I'd extract LCID lookup part to a function, then we easily do early return and the code will look simpler. Created attachment 156315 [details]
Patch 2
make a function
Comment on attachment 156305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156305&action=review >> Source/WebCore/platform/text/LocaleWin.cpp:81 >> + static LocaleWin* currentLocale; > > I'd extract LCID lookup part to a function, then we easily do early return and the code will look simpler. Indeed. Updated the patch. Committed r124721: <http://trac.webkit.org/changeset/124721> |