Bug 93079

Summary: [V8] Re-wire "target" half of the same-origin security check through Document rather than DOMWindow
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, eric, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92189, 93152    
Bug Blocks: 75793    
Attachments:
Description Flags
Remarkably close
none
Patch
none
Archive of layout-test-results from gce-cq-03 none

Adam Barth
Reported 2012-08-03 01:34:39 PDT
[V8] Re-wire "target" half of the same-origin security check through Document rather than DOMWindow
Attachments
Remarkably close (7.07 KB, patch)
2012-08-03 01:34 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (7.64 KB, patch)
2012-08-03 02:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cq-03 (324.56 KB, application/zip)
2012-08-03 22:32 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-03 01:34:58 PDT
Created attachment 156287 [details] Remarkably close
Adam Barth
Comment 2 2012-08-03 02:23:47 PDT
Created attachment 156297 [details] Patch
Eric Seidel (no email)
Comment 3 2012-08-03 02:26:37 PDT
Comment on attachment 156297 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2012-08-03 04:18:04 PDT
Comment on attachment 156297 [details] Patch Clearing flags on attachment: 156297 Committed r124594: <http://trac.webkit.org/changeset/124594>
WebKit Review Bot
Comment 5 2012-08-03 04:18:08 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2012-08-03 13:01:04 PDT
Re-opened since this is blocked by 93152
Adam Barth
Comment 7 2012-08-03 15:57:13 PDT
The test failure is because of Bug 92189.
Adam Barth
Comment 8 2012-08-03 21:36:57 PDT
Comment on attachment 156297 [details] Patch This should be safe to land again.
WebKit Review Bot
Comment 9 2012-08-03 22:32:52 PDT
Comment on attachment 156297 [details] Patch Rejecting attachment 156297 [details] from commit-queue. New failing tests: http/tests/cache/post-redirect-get.php http/tests/cache/post-with-cached-subresources.php fast/events/dispatch-message-string-data.html Full output: http://queues.webkit.org/results/13439034
WebKit Review Bot
Comment 10 2012-08-03 22:32:56 PDT
Created attachment 156515 [details] Archive of layout-test-results from gce-cq-03 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: gce-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
WebKit Review Bot
Comment 11 2012-08-04 00:31:58 PDT
Comment on attachment 156297 [details] Patch Clearing flags on attachment: 156297 Committed r124693: <http://trac.webkit.org/changeset/124693>
WebKit Review Bot
Comment 12 2012-08-04 00:32:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.