Bug 93038 – V8 bindings code that tries to find its context should use BindingState functions rather than V8Proxy

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

V8 bindings code that tries to find its context should use BindingState functions rather than V8Proxy

[Adam Barth]

Created attachment 156186 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156186 [details]
Patch

Attachment 156186 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13419652

New failing tests:
http/tests/misc/iframe-domain-test.html
http/tests/security/cookies/document-open.html
http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
http/tests/security/aboutBlank/security-context-window-open.html
http/tests/security/aboutBlank/security-context-with-base-tag.html
http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren.html
http/tests/security/aboutBlank/security-context-grandchildren-alias.html
http/tests/security/aboutBlank/security-context.html
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

[WebKit Review Bot]

Created attachment 156209 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Adam Barth]

Comment on attachment 156186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156186&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp:168
> -    Frame* frame = V8Proxy::retrieveFrameForCallingContext();
> +    Frame* frame = currentFrame(BindingState::instance());

Looks like I made a typo on this line.  This should be activeFrame like the other two examples in this file.  Yay tests!

[Adam Barth]

Created attachment 156218 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 156218 [details]
Patch for landing

Clearing flags on attachment: 156218

Committed r124547: <http://trac.webkit.org/changeset/124547>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.