Bug 93016

Summary: The generic bindings shouldn't use templates
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, eric.carlson, eric, feature-media-reviews, gyuyoung.kim, haraken, japhet, rakuco, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75793    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-08-02 12:08:07 PDT
The generic bindings shouldn't use templates
Attachments
Patch (75.73 KB, patch)
2012-08-02 12:12 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-02 12:12:01 PDT
Created attachment 156136 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-02 12:21:45 PDT
Comment on attachment 156136 [details] Patch LGTM, but where is JSC/BindingState? Does JSC not use this yet? Your ChangeLog is not clear on this part of the history.
Adam Barth
Comment 3 2012-08-02 13:03:06 PDT
> LGTM, but where is JSC/BindingState? Does JSC not use this yet? Your ChangeLog is not clear on this part of the history. JSC doesn't use this yet. I'm hoping to change that as part of this process, starting by making the code more attractive.
Adam Barth
Comment 4 2012-08-02 13:49:27 PDT
Comment on attachment 156136 [details] Patch Clearing flags on attachment: 156136 Committed r124492: <http://trac.webkit.org/changeset/124492>
Adam Barth
Comment 5 2012-08-02 13:49:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.