Bug 92694

Summary: nrwt: move the code that identifies the chunk of tests to run into finder
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92693    
Bug Blocks: 89267    
Attachments:
Description Flags
Patch
none
merge to r124131 rniwa: review+

Description Dirk Pranke 2012-07-30 17:16:43 PDT
nrwt: move the code that identifies the chunk of tests to run into finder
Comment 1 Dirk Pranke 2012-07-30 17:22:49 PDT
Created attachment 155405 [details]
Patch
Comment 2 Dirk Pranke 2012-07-30 18:14:25 PDT
Created attachment 155412 [details]
merge to r124131
Comment 3 Ryosuke Niwa 2012-07-30 18:23:59 PDT
Comment on attachment 155412 [details]
merge to r124131

View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399
> +        self._tests = set(self._test_files_list)

Why do we need to set this variable?
Comment 4 Dirk Pranke 2012-07-30 18:26:29 PDT
(In reply to comment #3)
> (From update of attachment 155412 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399
> > +        self._tests = set(self._test_files_list)
> 
> Why do we need to set this variable?

the manager code needs the tests both as a set and a list (order preserved), so we have to keep them in sync. This is really confusing; a later patch cleans this up.
Comment 5 Dirk Pranke 2012-07-30 18:40:44 PDT
Committed r124139: <http://trac.webkit.org/changeset/124139>