Summary: | nrwt: move the code that identifies the chunk of tests to run into finder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, ojan, rniwa, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 92693 | ||||||||
Bug Blocks: | 89267 | ||||||||
Attachments: |
|
Description
Dirk Pranke
2012-07-30 17:16:43 PDT
Created attachment 155405 [details]
Patch
Created attachment 155412 [details] merge to r124131 Comment on attachment 155412 [details] merge to r124131 View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399 > + self._tests = set(self._test_files_list) Why do we need to set this variable? (In reply to comment #3) > (From update of attachment 155412 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155412&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:399 > > + self._tests = set(self._test_files_list) > > Why do we need to set this variable? the manager code needs the tests both as a set and a list (order preserved), so we have to keep them in sync. This is really confusing; a later patch cleans this up. Committed r124139: <http://trac.webkit.org/changeset/124139> |